Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrape email addresses from URL #51

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Scrape email addresses from URL #51

merged 5 commits into from
Aug 3, 2023

Conversation

AI-Mozi
Copy link
Member

@AI-Mozi AI-Mozi commented Aug 3, 2023 •
edited
Loading

#43
I didn't know how to name this class 😅
It's a draft version, that I would like you to check and correct it because its hard for me to understand internal structure of ronin libs.

Also your opinion about specs here would help me with writing specs for other classes.

postmodern
postmodern requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Specs look good. Also good catch on using .force_encoding(Encoding::UTF_8), because sometimes HTTP responses are returned in ASCII-8bit encoding, which are incompatible with UTF-8 domain suffixes in the EMAIL_ADDRESS regex.

lib/ronin/recon/builtin/web/email.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/email.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/email.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/email.rb Outdated Show resolved Hide resolved
spec/builtin/web/email_spec.rb Outdated Show resolved Hide resolved
@postmodern postmodern changed the title Scrap email addresses from URL Scrape email addresses from URL Aug 3, 2023
postmodern
postmodern requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc fixes.

lib/ronin/recon/builtin/web/email_addresses.rb Outdated Show resolved Hide resolved
lib/ronin/recon/builtin/web/email_addresses.rb Outdated Show resolved Hide resolved
@postmodern postmodern merged commit e32f5da into ronin-rb:main Aug 3, 2023
3 of 4 checks passed
@postmodern postmodern mentioned this pull request Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @postmodern