Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to return integer value. #238

Closed
wants to merge 1 commit into from

Conversation

Sameer-Tilak
Copy link

This PR refer to issue #133.
Modified code to return value as integer if it is with General type and no decimal values or as number type with no decimal values (may need it as integer)

@stevendaniels
Copy link
Contributor

I've implemented similar functionality in #240, which includes type support for all cell types, not just integers.

@Sameer-Tilak
Copy link
Author

Is your branch merged to master?

In new changes you have changed the return value. Earlier it was float and not you are returning sting. All existing code that is based on original gem will fail and will have to modify.
I tried to maintain the return value.

@stevendaniels
Copy link
Contributor

The changes have not been merged into master yet.

#240 won't break existing code. The return values for cells remains the same for all types except for Boolean cells, which now return booleans instead of strings (see the test/test_roo.rb diff)

Your changes work for a subset of the type issues Roo has, but it doesn't solve the others. Additionally, your changes have some unresolved test failures.

@stevendaniels
Copy link
Contributor

Thanks for this pr. I'm closing due to #240.

thotmx added a commit to thotmx/roo that referenced this pull request Oct 9, 2015
  * Add numeric values in numbers1.ods
  * Add some tests to verify that it works
  * Add the same patch that roo-rb#238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants