Simplify Excelx::Sheet / SheetDoc division of labor #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.4%) to 93.972% when pulling a39d3962bb4e0af035d592e6b44b08d5c5a47069 on relationships-args into 1cbfe72 on master. |
Empact
force-pushed
the
relationships-args
branch
from
a39d396
to
30d3e83
Compare
Empact
force-pushed
the
relationships-args
branch
2 times, most recently
from
5bfe29d
to
0f3ca53
Compare
This removes the relationships argument from Sheet#cells and #hyperlinks, instead consistently relying on the relationships files from which the sheet was initialized. Sheet now simply delegates to SheetDoc for these methods, which removes a few cases of redundant memoization.
Rather than in ruby. Saves on allocations, etc.
Empact
force-pushed
the
relationships-args
branch
from
0f3ca53
to
e63d6b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary variability in relationships handling and redundant method definitions in Sheet.