Fix reading of a comment with an author in xlsx. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short version: comment with an author '<b>Eli Wang: </b>\ncomment content' was incorrectly extracted as only 'Eli Wang:' When an comment is created in MS Excel, the author name is automatically prefixed as <author name>: '. Roo was not handling this correctly - in such case, the comments xml node may contain multiple `/text/r/t` node instead of only one. The code extracting comments was only extract the first such node. As a result, the MS Excel generated comment "Mr Author: comment content" was extracted as "Mr Author:", for which is the first `/text/r/t` node. Furthermore, the comment in Excel is rich text, which is represented by multiple nodes in xml format. Therefore, extracting multiple nodes in a comment is always expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an comment is created in MS Excel, the author name is automatically prefixed as : '.
Roo was not handling this correctly - in such case, the comments xml node may contain multiple
/text/r/tnode instead of only one. The code extracting comments was only extract the first suchnode. As a result, the MS Excel generated comment "Mr Author: comment content" was extracted as "Mr
Author:", for which is the first
/text/r/tnode.Furthermore, the comment in Excel is rich text, which is represented by multiple nodes in xml format.
Therefore, extracting multiple nodes in a comment is always expected.
Summary
Short version: comment with an author "Eli Wang: \ncomment content" was incorrectly extracted
as only "Eli Wang:"