Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading of a comment with an author in xlsx. #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xenofex
Copy link

@Xenofex Xenofex commented Aug 20, 2021

When an comment is created in MS Excel, the author name is automatically prefixed as : '.
Roo was not handling this correctly - in such case, the comments xml node may contain multiple
/text/r/t node instead of only one. The code extracting comments was only extract the first such
node. As a result, the MS Excel generated comment "Mr Author: comment content" was extracted as "Mr
Author:"
, for which is the first /text/r/t node.

Furthermore, the comment in Excel is rich text, which is represented by multiple nodes in xml format.
Therefore, extracting multiple nodes in a comment is always expected.

Summary

Short version: comment with an author "Eli Wang: \ncomment content" was incorrectly extracted
as only "Eli Wang:"

Short version: comment with an author '<b>Eli Wang: </b>\ncomment content' was incorrectly extracted
as only 'Eli Wang:'

When an comment is created in MS Excel, the author name is automatically prefixed as <author name>: '.
Roo was not handling this correctly - in such case, the comments xml node may contain multiple
`/text/r/t` node instead of only one. The code extracting comments was only extract the first such
node. As a result, the MS Excel generated comment "Mr Author: comment content" was extracted as "Mr
Author:", for which is the first `/text/r/t` node.

Furthermore, the comment in Excel is rich text, which is represented by multiple nodes in xml format.
Therefore, extracting multiple nodes in a comment is always expected.
@patrickkulling
Copy link
Contributor

@Empact @kakubin This change is looking good to me. Test coverage is there as well.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants