Add support for excel sheet links #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code does not support excel sheet links, so we pass along a support_excel_sheet_hyperlinks flag in order to turn on the support for the excel sheet files when we create Roo:Excelx this ensures we do not break the old logic put in place for the rest of the links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current code does not support excel sheet links, so we pass along a support_excel_sheet_hyperlinks flag in order to turn on the support for the excel sheet files when we create Roo:Excelx, this ensures we do not break the old logic put in place for the rest of the links. The links will be presented in the following format "#Sheet2!A1".
I also removed some unnecessary method inputs since we were already passing along a global variable and defining it in the constructor. I added some tests and an example file.