Implement transaction indexer #1121
Conversation
baichuan3
requested review from
jolestar,
wow-sven and
pause125
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
crates/rooch-indexer/.env
Outdated
| @@ -0,0 +1 @@ | |||
| DATABASE_URL=/Users/Baichuan/.rooch/local/roochdb/indexer.sqlite | |||
There was a problem hiding this comment.
Is the DATABASE_URL must an absolute path?
There was a problem hiding this comment.
the .env is only for dev, and It should be removed from the crate.
| } | ||
|
|
||
| pub fn mock_indexer_store() -> Result<Self> { | ||
| let tmpdir = moveos_config::temp_dir(); |
There was a problem hiding this comment.
Should keep the temp_dir() returned DataDirPath. Otherwise, the temp dir will be removed when the DataDirPath instance is dropped.
There was a problem hiding this comment.
Fixed the problem of using temp path to release instance when server starts.
As for whether calling mock_indexer_store in the integration test will release it, I will write a test case to cover and verify it later.
| } | ||
|
|
||
| #[async_trait] | ||
| impl Handler<QueryTransactionsByHashMessage> for IndexerActor { |
There was a problem hiding this comment.
We can query transactions by hash from the transaction store, and does not need the index. Providing query transactions by the sender is more useful.
There was a problem hiding this comment.
Yes, the transactionFilter query RPC will be implemented in the following pr later to support queries including sender and other dimensions.
|
I will merge this PR first. |
Summary
part of #1028
Server startfailure prompt and supportedServer cleanto give the corresponding networkTODO
Solve the problem of automatic creation of Sqlite schema when
Server startand integration test. There are two optiondiesel migrate runto complete schema initialization, which means thatServer startand integration test have pre-dependenciesdiesel migrate runin rooch cli to eliminate pre-dependencies and the user experience will be smoother.Add more testcase