Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed travis tests #75

Merged
merged 1 commit into from
Jul 27, 2020
Merged

fixed travis tests #75

merged 1 commit into from
Jul 27, 2020

Conversation

cehbrecht
Copy link
Collaborator

@cehbrecht cehbrecht commented Jul 20, 2020 •
edited
Loading

This PR fixes tests on travis.

Changes:

  • pre-install udunits ... pip install fails without udunits headers.
  • added mock library needed by tests.
  • add pytest marker online to skip online tests (elasticsearch).
  • marked a couple of tests with xfail ... they fail on travis but not locally ...
  • ignore black test ... fails.

@cehbrecht cehbrecht added the bug Something isn't working label Jul 20, 2020
ellesmith88
ellesmith88 reviewed Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@ellesmith88 ellesmith88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@ellesmith88 ellesmith88 merged commit abeeccf into master Jul 27, 2020
@ellesmith88 ellesmith88 deleted the fix-travis-tests branch July 27, 2020 08:28
ellesmith88 added a commit that referenced this pull request Jun 21, 2021
@ellesmith88
Merge pull request #75 from roocs/fix-travis-tests
036cbd2 
fixed travis tests
ellesmith88 added a commit that referenced this pull request Jun 21, 2021
@ellesmith88
Merge pull request #75 from roocs/fix-travis-tests
bb5ddc2 
fixed travis tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellesmith88 ellesmith88 ellesmith88 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cehbrecht @ellesmith88