Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further configuration for ATLAS projects #113

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

sol1105
Copy link
Contributor

@sol1105 sol1105 commented Jan 26, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:
    I added/corrected project descriptions for the ATLAS projects. This is necessary to identify the ATLAS projects via the netCDF metadata.

  • Does this PR introduce a breaking change?:
    Not to my best knowledge.

  • Other information:

I added the necessary project description so the ATLAS projects can be determined from the netCDF metadata.
The ATLAS datasets have each 3 different project strings defined (sigh):

ATLAS v0 / c3s-ipcc-ar6-atlas:

  • in file-path: c3s-ipcc-ar6-atlas
  • in metadata:
    • :project = "IPCC-WGI AR6 Atlas" ;
    • :product = "ipcc-ar6-interactive-atlas-dataset" ;

ATLAS v1 / c3s-cica-atlas:

  • in file-path: c3s-cica-atlas
  • In metadata:
    • :project = "Copernicus Interactive Climate Atlas" ;
    • :product = "copernicus -interactive-climate-atlas-dataset" ;
      ( notice the space between "copernicus" and "-Interactive-climate-atlas-dataset" - likely a typo from when creating the files?!)

Therefore I defined two new projects in the roocs.ini labeled with whatever is defined as product in the ATLAS metadata and set the mapper to product rather than project_id. I copied all other settings from the original project definitions. clisops is then able to detect the project without problems. I do not know if all this could have been achieved easier, but I am not aware of the possibility to define aliases for project names or multiple mappings for project.

@sol1105
Copy link
Contributor Author

sol1105 commented Jan 26, 2024

@cehbrecht Please have a look. This PR fixes the problems I have in clisops with the project detection for both ATLAS versions. I do not have permissions for this repo, so I cannot select you as reviewer and have to create the PR from a fork.

@cehbrecht
Copy link
Contributor

@sol1105 good trick :) We can take it as "work-around" for now.

@cehbrecht
Copy link
Contributor

... we might extend the mappings in the roocs.ini. It currently only defines the attribute to check for the project. We could also provide an expected value.

@cehbrecht
Copy link
Contributor

@sol1105 works for me :) Can I merge?

@cehbrecht
Copy link
Contributor

@Zeitsperre we will add a better solution for this later ... just want to get it working now for atlas datasets.

@Zeitsperre
Copy link
Contributor

@cehbrecht

Sounds good. I still need to give a look over the latest comments/commits in CLISOPS. So long as everything gets a proper version and core functionality isn't affected, I trust your judgments.

@cehbrecht cehbrecht merged commit 5a7d925 into roocs:master Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants