-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add further configuration for ATLAS projects #113
Conversation
@cehbrecht Please have a look. This PR fixes the problems I have in |
@sol1105 good trick :) We can take it as "work-around" for now. |
... we might extend the |
…infering the project name.
@sol1105 works for me :) Can I merge? |
@Zeitsperre we will add a better solution for this later ... just want to get it working now for atlas datasets. |
Sounds good. I still need to give a look over the latest comments/commits in CLISOPS. So long as everything gets a proper version and core functionality isn't affected, I trust your judgments. |
Pull Request Checklist:
AUTHORS.md
What kind of change does this PR introduce?:
I added/corrected project descriptions for the ATLAS projects. This is necessary to identify the ATLAS projects via the netCDF metadata.
Does this PR introduce a breaking change?:
Not to my best knowledge.
Other information:
I added the necessary project description so the ATLAS projects can be determined from the netCDF metadata.
The ATLAS datasets have each 3 different project strings defined (sigh):
ATLAS v0 / c3s-ipcc-ar6-atlas:
:project = "IPCC-WGI AR6 Atlas" ;
:product = "ipcc-ar6-interactive-atlas-dataset" ;
ATLAS v1 / c3s-cica-atlas:
:project = "Copernicus Interactive Climate Atlas" ;
:product = "copernicus -interactive-climate-atlas-dataset" ;
( notice the space between
"copernicus"
and"-Interactive-climate-atlas-dataset"
- likely a typo from when creating the files?!)Therefore I defined two new projects in the
roocs.ini
labeled with whatever is defined asproduct
in the ATLAS metadata and set the mapper toproduct
rather thanproject_id
. I copied all other settings from the original project definitions.clisops
is then able to detect the project without problems. I do not know if all this could have been achieved easier, but I am not aware of the possibility to define aliases for project names or multiple mappings forproject
.