helm: rename values.yaml.tmpl to values.yaml

[k0da]

version can be set over values.yaml directly, there is no reason
to copy over a file, while lack of values.yaml file makes git tree
helm incompatible.

This is low effort fix for #3217

Signed-off-by: Dinar Valeev k0da@opensuse.org

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #3217

Checklist:

• Reviewed the developer guide on Submitting a Pull Request
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.
• Pending release notes updated with breaking and/or notable changes, if necessary.
• Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
• Code generation (make codegen) has been run to update object specifications, if necessary.
• Comments have been added or updated based on the standards set in CONTRIBUTING.md
• Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[k0da]

replicatedhq/ship#930

[travisn]

LGTM, the build is passing so it seems a minor thing that the .tmpl file wasn't needed. Tools like ship won't care that the values.yaml is unusable until the variable is replaced?

[k0da]

@travisn ship just runs some sort of helm template, to get you initial objects. A user still can set a tag to its own value. For helm/ship %%version%% is till valid value :)
Yes it is a little bit inconvenient, that you have to set tag, but at least that enable use rook chart through a gitpath and leverage ship/kustomize to maintain rook setup.