MVP + Coroutines

[rozkminiacz]

Refactor all major views to Model-View-Presenter with some RxKotlin support.

[AdamMc331]

This is right up my alley. MVP and Rx all the things!

…

On Mon, Oct 9, 2017, 6:56 PM Jarosław ***@***.***> wrote: Refactor all major views to Model-View-Presenter with some RxKotlin support. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJEz3ZoVonruFtyqGtdG5RMAxPy7XpG8ks5sqqSAgaJpZM4PzKGq> .

[Mauker1]

So will you do it @AdamMc331 ?

[AdamMc331]

I don't think I will have the time, but if it's not something you or Tristan can take on I can try. I don't know the whole code base but it might be an overhaul.

…

On Mon, Oct 9, 2017 at 7:17 PM Maurício C. P. Pessoa < ***@***.***> wrote: So will you do it @AdamMc331 <https://github.com/adammc331> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJEz3SylzugfVRIETwvFERURtObdNvHUks5sqql5gaJpZM4PzKGq> .

[Mauker1]

I think that it probably shouldn't be on the first version. We are already late to deploy it as it is right now.

[AdamMc331]

Yeah I've been thinking about this and it would be fun to try but I think it could be an overhaul and so it might be worth being done by itself, and not alongside other bug fixes as there could be merge issues.

[TimCastelijns]

I think it's better to do this sooner rather than later. Proper structure takes some time now, makes everything easier now and in the future. Doing the MVP rework after release might also introduce bugs because much will change

[raghunandankavi2010]

MVVM and databinding with repository pattern?. we could start with LoginActivity!.

[TimCastelijns]

We discussed it briefly. Plan for now is to do MVP, with Rxjava where appropriate. Would like to use coroutines in the future, but we lack experience at the moment.

[TimCastelijns]

Rx is dead, long live coroutines