Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Forked Pull Requests #72

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

twslade
Copy link
Contributor

@twslade twslade commented Sep 21, 2020

Closes #71

Note that 2c9163b fixes an issue in with PR below but can be removed if you want to stay on circleci/circleci-cli@0.1.8 orb.
CircleCI-Public/circleci-cli#444

@roopakv
Copy link
Owner

roopakv commented Sep 21, 2020

@twslade yeah i plan to update the circle-cli orb. I shall do so this weekend. for now let us confitnue with this :)

Copy link
Owner

@roopakv roopakv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not make this change for now. I'll come back to this in the future

src/commands/get-job-number.yml Outdated Show resolved Hide resolved
src/commands/trigger-pipeline.yml Outdated Show resolved Hide resolved
@roopakv
Copy link
Owner

roopakv commented Sep 22, 2020

thank you @twslade

@roopakv roopakv merged commit 9c10a0d into roopakv:master Sep 22, 2020
@roopakv
Copy link
Owner

roopakv commented Sep 22, 2020

@twslade published version v0.52.0 with the support for forked pull requests.

the one thing for you to keep in mind is that you will need a circle-token to trigger the pull requests. Please make sure that it isn't abused :)

@twslade
Copy link
Contributor Author

twslade commented Sep 22, 2020

@roopakv sounds good. It's not a public fork so we understand the implications. Thanks again for a great tool!

@twslade twslade deleted the feature/orb-pulls branch September 23, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triggering Forked Pull Requests Pipeline
2 participants