Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build instructions #518

Closed
wants to merge 1 commit into from
Closed

Conversation

Arcnor
Copy link

@Arcnor Arcnor commented Jan 31, 2024

This is a very simple PR to improve the CMake build instructions. The existing ones are a bit too convoluted and can be simplified a lot, plus there is an issue mentioned at #515 about the NVPTX using the wrong name, which leads to a misleading error. (The first issue mentioned there about the build type only shows when you configure CMake with a non-multi-config generator, so I've left that one alone for the time being).

I hope this helps!

@daniel347x-cs
Copy link

This simple PR seems super important to me. I wonder how many people, almost like myself, spending hours trying to follow the build instructions and failing, simply give up and don't use it or become involved.

Seems a shame not to make the very simple change of providing proper build instructions in the README that work in 2024.

@ferdymercury ferdymercury requested review from vgvassilev and removed request for vgvassilev April 12, 2024 09:02
@ferdymercury
Copy link
Contributor

I believe this repo acts as a mirror, please move your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks

@LiAuTraver
Copy link
Contributor

Really spent a whole day failing finally found issue😭wish I could find this PR earlier but, until now neither the root nor this repo has fixed this instruction error, sadly it's half-year passed.

@ferdymercury
Copy link
Contributor

ferdymercury commented Jul 2, 2024

Yes, it's a pity, but devs are quite overloaded afaik. This repo only gets (automatically) fixes from root, so this PR has more chances of getting reviewed if moved to the root repo.

@LiAuTraver
Copy link
Contributor

Yes you are right. Plus i searched the PR/issue at root but not found any similiar problem. I create one myself root-project/root#15972 (comment). I really wish people come after do not ran into this problem, for it's a painful process building from source on an ordinary computer which results my PC was forced to shutdown several times. 😭

@ferdymercury
Copy link
Contributor

Thanks for moving the PR there, I'll close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants