Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide different way to input value instead of prompt #216

Closed
linev opened this issue Apr 12, 2021 · 5 comments
Closed

Provide different way to input value instead of prompt #216

linev opened this issue Apr 12, 2021 · 5 comments
Assignees
@linev
Labels
enhancement

Comments

@linev
Copy link
Member

linev commented Apr 12, 2021

Could help to solve AlbertoPdRF/root-file-viewer#6
@linev linev self-assigned this Apr 12, 2021
@linev linev mentioned this issue Apr 12, 2021
Closed
@linev
Copy link
Member Author

linev commented Apr 12, 2021

Seems to be, one can use modal forms

https://jqueryui.com/dialog/#modal-form

Moreover, it is also can be applied for TWebCanvas without openui5

linev added a commit that referenced this issue Apr 13, 2021
@linev
Use jquery Dialog to input value in menu #216
b4571e3 
Avoid usage of prompt, which may be not supported in some environment.
Use Promise to return value.
linev added a commit that referenced this issue Apr 13, 2021
@linev
Let configure input type #216
888ac20
@linev
Copy link
Member Author

linev commented Apr 13, 2021

Now jquery dialog class is used to input values.
prompt left in few places, which will be removed later

@linev linev closed this as completed Apr 13, 2021
@AlbertoPdRF
Copy link

That's awesome @linev, thanks a lot for this! Do you plan to include these changes (and the re-binning ones from #210) in a release?

@linev
Copy link
Member Author

linev commented Apr 13, 2021

Yes, in next deys I plan to make 6.1.0 release

@AlbertoPdRF
Copy link

Great, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linev linev

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linev @AlbertoPdRF