[IO] Improve error message when no TFile::Open for remote files #11719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides making control flow harder to follow, it makes it harder to introduce other early returns as compilers will not allow goto calls that cross variable initializations.
|
Starting build on |
pcanal
approved these changes
Nov 16, 2022
Comment on lines
+324
to
+325
| R__LOCKGUARD(gROOTMutex); | ||
| gROOT->GetListOfClosedObjects()->Add(this); |
There was a problem hiding this comment.
Suggested change
| R__LOCKGUARD(gROOTMutex); | |
| gROOT->GetListOfClosedObjects()->Add(this); | |
| gROOT->GetListOfClosedObjects()->Add(this); |
The list of Closed Objects has its won locked nowadays (yes, I don't know why it was not removed sooner).
There was a problem hiding this comment.
this looks completely unrelated, it should probably be done in a separate PR for all occurrences of the pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to mark the file as zombie when this happens, I had to change a
goto zombieinto calls to a dedicated helper lambda (done in a separate commit). Otherwise I would have had to move around a few lines just so that the compiler would let me jump from the sanity check to the zombie label (compilers don't allow jumps across variable initializations).This fixes #10039.