Set kMustCleanup bit for all pad primitives when streaming #13539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When primitive add to the pad via TObjectt::AppendPad, kMustCleanup bit is automatically set for that object. But when primitives read from the IO buffer, TH1::Streamer reset that bit in IO. This has side effect afterwards, when pad is deleted during ROOT shutdown and when pad has same histogram twice in list of primitives.
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. |
|
Build failed on mac11/noimt. Failing tests: |
pcanal
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When primitive add to the pad via
TObjectt::AppendPad()method,kMustCleanupbit is automatically set for that object.But when primitives read from the IO buffer,
TH1::Streamer reset
kMustCleanupin IO.This has side effect afterwards, when pad is deleted during ROOT shutdown and when pad has same histogram twice in list of primitives.
Replaces #13506