Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for first batch of Vectorized TMath functions #79

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

ArifAhmed1995
Copy link
Contributor

This PR implements benchmarks(similar to ones in VecCore) for first batch of Vectorized TMath functions.

Reference : #2236

@oshadura
Copy link
Collaborator

oshadura commented Feb 5, 2019

@ArifAhmed1995, I see that this PR is connected to root-project/root#2236, I will relaunch CI when PR #2236 will land in ROOT.

@oshadura oshadura requested a review from amadio February 5, 2019 16:03
@ArifAhmed1995
Copy link
Contributor Author

@oshadura The changes from #2236 are now a part of ROOT. The Travis CI build has passed too.
Is there any other changes that you would suggest ?
Also tagging @amadio .

@oshadura
Copy link
Collaborator

LGTM!

@amadio amadio merged commit e55ea00 into root-project:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants