Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove example of creating a ROOT::UnBinData from a TH1 #941

Closed
guitargeek opened this issue Dec 1, 2023 · 0 comments · Fixed by #989
Closed

Remove example of creating a ROOT::UnBinData from a TH1 #941

guitargeek opened this issue Dec 1, 2023 · 0 comments · Fixed by #989
Assignees
@guitargeek

Comments

@guitargeek
Copy link
Contributor

This is a bad example, because a histogram is meant to reduce the data, and it's not a good idea to use the buffer to try to get the original unbinned data. The buffer might be already cleared or not. A better example would maybe be from a vector, NumPy array or CSV file.
guitargeek added a commit to guitargeek/web that referenced this issue Apr 26, 2024
@guitargeek
Don't use TH1::GetBuffer() in example code for RooFit::UnBinData
a3d7d16 
This is a bad example, because a histogram is meant to reduce the data,
and it's not a good idea to use the buffer to try to get the original
unbinned data.

Closes root-project#941.
@guitargeek guitargeek mentioned this issue Apr 26, 2024
Merged
guitargeek added a commit that referenced this issue Apr 26, 2024
@guitargeek
Don't use TH1::GetBuffer() in example code for RooFit::UnBinData
2ca3e9d 
This is a bad example, because a histogram is meant to reduce the data,
and it's not a good idea to use the buffer to try to get the original
unbinned data.

Closes #941.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guitargeek guitargeek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use TH1::GetBuffer() in example code for RooFit::UnBinData guitargeek/web
1 participant
@guitargeek