api: raise an error if the socket path is too long #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
detect-too-long-api-socket
branch
2 times, most recently
from
5d3857f
to
1fe8a83
Compare
AkihiroSuda
reviewed
Nov 4, 2019
api.c
Outdated
| fprintf(stderr, "the specified API socket path is too long (> %d)\n", sizeof(addr.sun_path)); | ||
| return -1; | ||
| } | ||
| strcpy(addr.sun_path, api_socket); |
There was a problem hiding this comment.
I think we should use strncpy everytime to avoid potential lint false-positive
There was a problem hiding this comment.
also make sure to terminate with NUL
There was a problem hiding this comment.
moved back to strncpy.
The addr.sun_path string is NUL terminated since we have memset(&addr, 0, sizeof(addr));
giuseppe
force-pushed
the
detect-too-long-api-socket
branch
from
1fe8a83
to
59f860f
Compare
AkihiroSuda
reviewed
Nov 4, 2019
api.c
Outdated
| @@ -21,6 +21,11 @@ int api_bindlisten(const char *api_socket) | |||
| } | |||
| memset(&addr, 0, sizeof(addr)); | |||
| addr.sun_family = AF_UNIX; | |||
| if (strlen(api_socket) >= sizeof(addr.sun_path)) { | |||
| fprintf(stderr, "the specified API socket path is too long (> %lu)\n", | |||
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
detect-too-long-api-socket
branch
from
59f860f
to
b08917a
Compare
AkihiroSuda
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com