Refund logic #21
Merged
Refund logic #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # contracts/PensionFundRelease.sol # test/PensionFundReleaseTest.js
frostiq
suggested changes
Aug 23, 2017
contracts/PensionFundRelease.sol
Outdated
| // Confirm validators have refunded funds | ||
| require(isBurnApproved()); | ||
| // Confirm the next payment is due to be released | ||
| require(isFundFreezePeriodEnded()); |
There was a problem hiding this comment.
I think we can allow to burn even before the paymentTime
contracts/PensionFundRelease.sol
Outdated
| refundedAmount = getPaymentAmount(); | ||
| firtPaymentReleased = true; | ||
| } else { | ||
| refundedAmount = getPaymentAmount(); |
There was a problem hiding this comment.
We need to return all remaining amount, not next payment amount
contracts/PensionFundRelease.sol
Outdated
| refundedAmount = balance(); | ||
| } | ||
| // Assumes intended interval is meant to recur regardless of claiming funds | ||
| paymentTime = paymentTime + recurrentPaymentInterval; |
There was a problem hiding this comment.
we don't need to update paymentTime in burn case
test/PensionFundReleaseTest.js
Outdated
| firstPaymentPercent, | ||
| token.address, | ||
| PAYOUT_PERCENT | ||
| it("#14 should refund all roots and then refund balance of 0", async() => { |
There was a problem hiding this comment.
Please, don't forget to change tests after your changes in PR.
You need just to check that all ether amount are refunded, if burn was approved.
And also a negative scenario (burn was not approved -> failure)
# Conflicts: # migrations/2_deploy_IouRootsToken.js # migrations/3_deploy_PensionFundRelease.js # test/IouRootsTokenTest.js # test/PensionFundReleaseTest.js # truffle.js
|
relates to #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.