You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some digging I found out about the preflight config in config/app.php but after enabling it warnings remained. Looks like Roots\Acorn\Application::bootProvider() first checks for boot() method and if it exists it just calls it in return while the preflight check comes after that but because Roots\Acorn\View\ViewServiceProvider provides the boot method the preflight is never called.
I would do a PR but I'm not entirely sure what approach is best since I'm not that much into the logic behind Application-ServiceProvider architecture. One would simply move the preflight check before boot is called or move it directly under the Service class itself.
The text was updated successfully, but these errors were encountered:
Yeah this is something I was aware of when adding preflight as an option. The change in the logic is actually why tests are failing now.
I had figured it out in my head at the time how I could resolve it, but I never put it into code and now I don't remember where I was wanting to go with it.
Thanks for taking the time to test Sage 10 and report this issue.
I was playing around with the sage 10 branch and first thing I saw was warnings of the kind:
After some digging I found out about the
preflight
config inconfig/app.php
but after enabling it warnings remained. Looks likeRoots\Acorn\Application::bootProvider()
first checks forboot()
method and if it exists it just calls it in return while the preflight check comes after that but becauseRoots\Acorn\View\ViewServiceProvider
provides the boot method the preflight is never called.I would do a PR but I'm not entirely sure what approach is best since I'm not that much into the logic behind Application-ServiceProvider architecture. One would simply move the preflight check before boot is called or move it directly under the Service class itself.
The text was updated successfully, but these errors were encountered: