ViewServiceProvider::preflight() never called

[entr]

I was playing around with the sage 10 branch and first thing I saw was warnings of the kind:

PHP Warning:  file_put_contents(.../acorn/cache/3ea2c06f9c61888a9945ac4a2e2619a24c0457da.php)

After some digging I found out about the preflight config in config/app.php but after enabling it warnings remained. Looks like Roots\Acorn\Application::bootProvider() first checks for boot() method and if it exists it just calls it in return while the preflight check comes after that but because Roots\Acorn\View\ViewServiceProvider provides the boot method the preflight is never called.

I would do a PR but I'm not entirely sure what approach is best since I'm not that much into the logic behind Application-ServiceProvider architecture. One would simply move the preflight check before boot is called or move it directly under the Service class itself.

[QWp6t]

Yeah this is something I was aware of when adding preflight as an option. The change in the logic is actually why tests are failing now.

I had figured it out in my head at the time how I could resolve it, but I never put it into code and now I don't remember where I was wanting to go with it.

Thanks for taking the time to test Sage 10 and report this issue.

[QWp6t]

This was fixed at some point, but I don't recall exactly which commit it was.