Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request] add support for react v18 #1955

Closed
aceArt-GmbH opened this issue Dec 26, 2022 · 3 comments
Closed

[request] add support for react v18 #1955

aceArt-GmbH opened this issue Dec 26, 2022 · 3 comments
Assignees
@kellymears
Labels
dependencies Pull requests that update a dependency file @roots/bud-react

Comments

@aceArt-GmbH
Copy link

As defined in the package.json bud-react currently requires react and react-dom in version 17. (https://github.com/roots/bud/blob/main/sources/%40roots/bud-react/package.json#L100)

Is there any chance to get this updated to be able to use react version 18?

I also opened a topic in the roots forum, because for me my current project setup does not work using react-dom in version 17. (https://discourse.roots.io/t/sage-10-with-react-18/24458/5)

Thanks for your help & kind regards!
@kellymears kellymears added dependencies Pull requests that update a dependency file @roots/bud-react labels Jan 1, 2023
@kellymears kellymears self-assigned this Jan 1, 2023
@kellymears
Copy link
Member

I was waiting for wordpress/gutenberg to update to React 18 and it looks like they have now.

For now you can use react 18 by installing it to your project. react and react-dom will both use any version you specify in package.json:

bud/sources/@roots/bud-react/package.json

Lines 108 to 109 in bd34d07

"react": "*",
"react-dom": "*"

@kellymears kellymears mentioned this issue Jan 1, 2023
Merged
@kellymears
Copy link
Member

kellymears commented Jan 1, 2023 •
edited
Loading

I should have read your discourse topic more closely. I see that you are already trying to override. The linked PR should fix this.

kodiakhq bot pushed a commit that referenced this issue Jan 2, 2023
@kellymears
🩹 fix(@roots/bud-react): allow overriding react version (#1974)
e0e2829 
- we use [vadimdemedes/ink](https://github.com/vadimdemedes/ink) which is stuck on react < 18. 
- development on ink has slowed due to the situation in ukraine but it looks like they're prepping a release for react 18
- in the meantime i went through and ensured all references to React umd point to `@roots/bud-support/react`
- set up a reproduction with react 18
- no changes needed in config
- merged #1973 onto this since they are similar in many ways

## Unrelated (housekeeping)
- adds [@repo/markdown-kit/contributors/index.js](https://github.com/roots/bud/blob/aa8a7279b378e7bedff7428af3ea7ada329e27f6/sources/%40repo/markdown-kit/contributors/index.js) to aggregate contributors per package in a `contributors.yml` file. root `contributors.yml` applies to the entire repo.

refers:

- #1955

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
@kellymears
Copy link
Member

Let me know if this doesn't work but we have tests set up for it and all seems to be behaving normally in local projects, for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellymears kellymears

Labels
dependencies Pull requests that update a dependency file @roots/bud-react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellymears @aceArt-GmbH