-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ improve: peer dependencies vendoring #1973
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@roots/bud
@roots/bud-api
@roots/bud-babel
@roots/bud-build
@roots/bud-client
@roots/bud-compiler
@roots/bud-compress
@roots/bud-criticalcss
@roots/bud-dashboard
@roots/bud-emotion
@roots/bud-entrypoints
@roots/bud-esbuild
@roots/bud-eslint
@roots/bud-extensions
@roots/bud-framework
@roots/bud-hooks
@roots/bud-preset-recommend
@roots/bud-preset-wordpress
@roots/bud-prettier
@roots/bud-purgecss
@roots/bud-react
@roots/bud-sass
@roots/bud-server
labels
Dec 31, 2022
github-actions
bot
added
@roots/bud-stylelint
@roots/bud-support
@roots/bud-swc
@roots/bud-tailwindcss
@roots/bud-terser
@roots/bud-typescript
@roots/bud-wordpress-dependencies
@roots/bud-wordpress-externals
@roots/bud-wordpress-manifests
@roots/critical-css-webpack-plugin
@roots/dependencies
@roots/entrypoints-webpack-plugin
@roots/eslint-config
@roots/filesystem
@roots/merged-manifest-webpack-plugin
@roots/sage
@roots/wordpress-dependencies-webpack-plugin
@roots/wordpress-externals-webpack-plugin
@roots/wordpress-hmr
config
dependencies
Pull requests that update a dependency file
docs
internal
repository specific PR or issue
test
labels
Dec 31, 2022
merged onto #1973 |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 2, 2023
- we use [vadimdemedes/ink](https://github.com/vadimdemedes/ink) which is stuck on react < 18. - development on ink has slowed due to the situation in ukraine but it looks like they're prepping a release for react 18 - in the meantime i went through and ensured all references to React umd point to `@roots/bud-support/react` - set up a reproduction with react 18 - no changes needed in config - merged #1973 onto this since they are similar in many ways ## Unrelated (housekeeping) - adds [@repo/markdown-kit/contributors/index.js](https://github.com/roots/bud/blob/aa8a7279b378e7bedff7428af3ea7ada329e27f6/sources/%40repo/markdown-kit/contributors/index.js) to aggregate contributors per package in a `contributors.yml` file. root `contributors.yml` applies to the entire repo. refers: - #1955 ## Type of change **PATCH: backwards compatible change** This PR includes breaking changes to the following core packages: - none This PR includes breaking changes to the follow extensions: - none ## Dependencies ### Adds - none ### Removes - none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
config
dependencies
Pull requests that update a dependency file
docs
internal
repository specific PR or issue
@roots/bud
@roots/bud-api
@roots/bud-babel
@roots/bud-build
@roots/bud-client
@roots/bud-compiler
@roots/bud-compress
@roots/bud-criticalcss
@roots/bud-dashboard
@roots/bud-emotion
@roots/bud-entrypoints
@roots/bud-esbuild
@roots/bud-eslint
@roots/bud-extensions
@roots/bud-framework
@roots/bud-hooks
@roots/bud-preset-recommend
@roots/bud-preset-wordpress
@roots/bud-prettier
@roots/bud-purgecss
@roots/bud-react
@roots/bud-sass
@roots/bud-server
@roots/bud-solid
@roots/bud-stylelint
@roots/bud-support
@roots/bud-swc
@roots/bud-tailwindcss
@roots/bud-terser
@roots/bud-typescript
@roots/bud-wordpress-dependencies
@roots/bud-wordpress-externals
@roots/bud-wordpress-manifests
@roots/critical-css-webpack-plugin
@roots/dependencies
@roots/entrypoints-webpack-plugin
@roots/eslint-config
@roots/filesystem
@roots/merged-manifest-webpack-plugin
@roots/sage
@roots/wordpress-dependencies-webpack-plugin
@roots/wordpress-externals-webpack-plugin
@roots/wordpress-hmr
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for after #1972
refers:
Type of change
PATCH: backwards compatible change
This PR includes breaking changes to the following core packages:
This PR includes breaking changes to the follow extensions:
Dependencies
Adds
Removes