-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#42 Support Webpack v5 #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellymears
added
dependencies
Pull requests that update a dependency file
@roots/bud-framework
webpack
labels
Apr 4, 2021
kellymears
commented
Apr 4, 2021
*/ | ||
public htmlWebpackPlugin: HtmlWebpackPlugin | ||
public htmlWebpackPlugin: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something weird happening with this type definition. Setting to any
temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Affected packages
Issues fixed
Details
This is a work-in-progress.
Todo
Notes
optimize-css-assets-webpack-plugin
throws warnings. Docs say to usecss-minimizer-webpack-plugin
instead.bud.vendor
method from@roots/bud-api
. Replaced withbud.splitChunks
.build/optimization/splitChunks/chunks
build/optimization/splitChunks/minSize
build/optimization/splitChunks/maxSize
build/optimization/splitChunks/maxAsyncRequests
build/optimization/splitChunks/maxInitialRequests
build/optimization/splitChunks/cacheGroups
build/optimization/splitChunks/cacheGroups/vendor
build/optimization/splitChunks/cacheGroups/vendor/priority
build/optimization/splitChunks/cacheGroups/vendor/...
(everything from here on is gone)vendor
chunk either need to include the config keys betweensplitChunks
andvendor
in the config param ofbud.splitChunks
, or overwrite the config in total usingbud.hooks.on('build/optimization/splitChunks')
.parallelism
value ofos.cpus().length - 1
(previously set to1
)src
,srcPath
,dist
,distPath
,project
api fns in favor of a consolidated approach:bud.path
andbud.setPath
.@roots/bud-support
. Types should be imported usingimport type
directly from the package. Packages which export types should be added to the repo root package.json.@roots/bud-compiler
no longer derives its type definition from@roots/bud-typings
. See: Deprecate internal usage of @roots/bud-typings #48.@roots/bud-build
no longer derives its type definition from@roots/bud-typings
. See Deprecate internal usage of @roots/bud-typings #48.processAssets
hook. webpack 5 no longer allows assets to be modified during the compileremit
phase.yml
andjson
)bud.production.config.js
, etc.)