Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve @roots/bud-dashboard typings #47

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Improve @roots/bud-dashboard typings #47

merged 3 commits into from
Apr 8, 2021

Conversation

kellymears
Copy link
Member

Type of change

  • PATCH: bugfix

Affected packages

  • @roots/bud
  • @roots/bud-framework
  • @roots/bud-dashboard
  • @roots/bud-typings

Dependencies added

Issues fixed

None

Details

  • Loosens coupling of @roots/bud-framework and @roots/bud-dashboard. Dashboard still relies on Framework definitions but no longer the other way around.
  • Removes dependency on @roots/bud-typings.
  • Moves plenty of minor type definitions out of component files and into the src/interface.ts file.

@kellymears kellymears self-assigned this Apr 7, 2021
@kellymears kellymears added this to the 3.1 milestone Apr 7, 2021
@kellymears kellymears mentioned this pull request Apr 7, 2021
Closed
12 tasks
@kellymears kellymears modified the milestones: 3.1, 3.2 Apr 8, 2021
@kellymears kellymears merged commit f364d0e into stable Apr 8, 2021
@QWp6t QWp6t deleted the dashboard-typings branch May 20, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kellymears kellymears

Labels
@roots/bud @roots/bud-dashboard @roots/bud-framework @roots/bud-typings
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
1 participant
@kellymears