Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky footer #46

Closed
johnraz opened this issue May 4, 2011 · 4 comments
Closed

Sticky footer #46

johnraz opened this issue May 4, 2011 · 4 comments

Comments

@johnraz
Copy link
Contributor

johnraz commented May 4, 2011

What about making this an option ?
http://www.cssstickyfooter.com/

@retlehs
Copy link
Member

retlehs commented May 4, 2011

falls outside of roots, imo

@retlehs retlehs closed this as completed May 4, 2011
@johnraz
Copy link
Contributor Author

johnraz commented May 4, 2011

mmm I don't agree fully.

It's an often required feature and it's a pain to integrate because it requires some particular html structure.
Adding an option to "make the footer stick in the bottom" couldn't hurt roots, does it ?

What do you think ?

I will implement it for myself anyway, let me know if you want to integrate it at some point.
Cheers ;-)

@retlehs
Copy link
Member

retlehs commented May 4, 2011

you could modify footer.php so that #wrap closes before footer starts, and then your html will be good to use according to that site

i'd rather not add that css + the option, i personally have never used a sticky css footer and it doesn't seem to be something that's regularly used/a standard [anymore]

we wouldn't want to serve an additional stylesheet and we can't insert the sticky footer css in style.css only if the option is enabled

we should keep the style.css as minimal as possible (i'm considering gutting large chunks of it)

@johnraz
Copy link
Contributor Author

johnraz commented May 5, 2011

Ok. You made your point. I agree with minimalism.
I'll document it in the wiki with clear informations to help people who wants to implement it.

oxyc pushed a commit to generoi/sage that referenced this issue May 10, 2019
Better docs on WPackagist and their new namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants