Changed inline @php directive to full form #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpouldev
changed the title
|
We could also recreate the previous behavior with a new directive. /**
* Create @inline() Blade directive
*/
sage('blade')->compiler()->directive('inline', function ($php) {
return "<?php $php; ?>";
});<html @inline(language_attributes())> |
|
I've tried that already but it has the same behavior like this laravel/framework#20065 (see laravel/framework#22621 (comment)). It's rare for someone to put blade markup inside php, but ¯_(ツ)_/¯ I prefer to have "vanilla" this basic behavior |
|
tyvm |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #2012 issue, Laravel 5.5 dropped support for inline
@phpdirective like@php(). On this PR I changed every inline to full form. I've already reproduce the issue on my sage-woo fork.