Revert "Add searchform partial and function to replace default WordPress functionality"

[retlehs]

Reverts #2090

Closes #2105 #2109

[garrettw]

So is there some other forthcoming fix for the broken search form?

[retlehs]

this is the fix...

[garrettw]

What I mean is, #2090 was supposed to fix get_search_form() so if that's been reverted, what's the new solution?

[retlehs]

not sure what you mean? #2090 doesn't fix get_search_form - it was a new feature that introduced some bugs (#2101 #2105). this reverts it.

[garrettw]

Meh, never mind I guess. Maybe I misunderstood what was meant by "letting users use get_search_form() as normal".

[mmirus]

@garrettw been a bit, but if memory serves, the problem solved by #2090 was that if you wanted to use a custom template for the search form you needed to filter get_search_form to work with the Sage folder structure and Blade.

We may incorporate something similar to this again in a future Sage release, but in the meanwhile you can use the changes from #2090 and #2109 if you want to override the search form partial in your project.