Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the base form object #1

Merged
merged 5 commits into from
Mar 10, 2020
Merged

Adding the base form object #1

merged 5 commits into from
Mar 10, 2020

Conversation

juanmanuelramallo
Copy link
Collaborator

  • Added the initial implmentation of the form object
  • Added a basic spec
  • Added support for ActiveRecord in specs with an sqlit3 adapter and an in-memory db

santib
santib reviewed Feb 14, 2020
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
lib/yaaf/base.rb Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
lib/yaaf/form.rb
true
end

def after_commit; end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these hooks can be private. Try it out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can do these in a subsequent PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

santib
santib reviewed Feb 14, 2020
View reviewed changes
lib/yaaf/form.rb Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
lib/yaaf/form.rb Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
lib/yaaf/form.rb

validate :validate_models

def save
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have save! to provide a similar API such as ActiveModel ?

def save!
  save_in_transaction
  after_commit
end

def save
  before_validation
  return false if invalid?

  save!
  true
end

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Definitely, do you think a subsequent PR would work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
spec/yaaf/form_spec.rb Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
santib
santib reviewed Feb 14, 2020
View reviewed changes
gem-base.gemspec Outdated Show resolved Hide resolved
This was referenced Feb 14, 2020
Closed
Closed
@juanmanuelramallo
Adding the base form object
0082d5c 
- Added the initial implmentation of the form object
- Added a basic spec
- Added support for ActiveRecord in specs with an sqlit3 adapter and an in-memory db
@juanmanuelramallo
Updating after comments
baac62b 
- Adding database cleaner
- Improving specs
- Updating gemspec
santib
santib reviewed Mar 2, 2020
View reviewed changes
yaaf.gemspec Outdated Show resolved Hide resolved
santib
santib approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@santib santib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

jpascual1994
jpascual1994 approved these changes Mar 3, 2020
View reviewed changes
Copy link

@jpascual1994 jpascual1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

fedeagripa
fedeagripa reviewed Mar 5, 2020
View reviewed changes
spec/support/schema.rb Show resolved Hide resolved
spec/support/models.rb Outdated Show resolved Hide resolved
@juanmanuelramallo juanmanuelramallo merged commit 379b607 into master Mar 10, 2020
@juanmanuelramallo juanmanuelramallo deleted the base-form branch March 10, 2020 21:34
@thewatts thewatts mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santib santib santib approved these changes

@fedeagripa fedeagripa fedeagripa approved these changes

@jpascual1994 jpascual1994 jpascual1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanmanuelramallo @santib @fedeagripa @jpascual1994