Normalize path for render_root in yml to fix relative paths #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slager
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue found by @jmtaylor-fhcrc during interactive testing where
rmarkdown::render()fails when render_root is given as./in yml config.Basically, render_root path needs to be normalized before passing to
rmarkdown::render().This originally happened but got broken by commit 519fadb.
Fixed the regression and added new tests for the behavior expected by Jason's reprex.
Internal function
.validate_render_root()has been changed to return the normalized render_root path if the path is valid or throw an error if it's invalid. The old behavior was to catch the error and return TRUE or FALSE.