Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About update-tic.yml #79

Closed
pat-s opened this issue Jul 29, 2020 · 12 comments
Closed

About update-tic.yml #79

pat-s opened this issue Jul 29, 2020 · 12 comments

Comments

@pat-s
Copy link
Member

pat-s commented Jul 29, 2020

Hi Adam,

in order for update-tic.yml to work, you need to add a secret with "workflow" scopes named "TIC_UPDATE" to your repo.

This can be easily done via tic::gha_add_secret(<secret>, "TIC_UPDATE").

Just letting you know since you are one of the few persons who were keen enough to try this new functionality :)

@adamhsparks
Copy link
Member

Right, thanks for that. I had a feeling I was missing something here but got sidetracked and didn't investigate further.

@pat-s
Copy link
Member Author

pat-s commented Aug 12, 2020

Hi Adam, just wondering if something is still unclear since the update-tic action is still erroring due to the lack of the secret?

@adamhsparks
Copy link
Member

Is it? I thought it all ran fine.

tic::gha_add_secret(<secret>, "TIC_UPDATE")

Where <secret> was my GH PAT with a "workflow" scope. So, yes, I guess something wasn't clear to me because I thought it was working now. 😕

@adamhsparks adamhsparks reopened this Aug 12, 2020
@adamhsparks
Copy link
Member

Ah, I fixed a different issue that I was having. Dang.

OK, no, it's not clear. Sorry, I don't understand what needs to be done here.

@pat-s
Copy link
Member Author

pat-s commented Aug 12, 2020

The PR creation fails because you renamed your default branch from master to main: https://github.com/ropensci/GSODR/runs/974227217?check_suite_focus=true#step:6:100

Maybe updating the action helps (just run tic::use_update_tic()) again. If not, you need to set the new default branch name in the "create-pull-request" action manually.

@adamhsparks
Copy link
Member

adamhsparks commented Aug 12, 2020 via email

@adamhsparks
Copy link
Member

OK, I just feel dumb. I know that the YAML, update-tic.yml, specifies "main" not "master" but it's still failing when I trigger a build.

I thought that I had even updated that before I even ran tic::use_update_tic() just now, but now I know for sure that I've done both and it still fails.

@pat-s
Copy link
Member Author

pat-s commented Aug 12, 2020

I do not see it failing. Note that the action is only run once a day in cron job. Where do you see it failing?

LGTM on the first look.

@adamhsparks
Copy link
Member

adamhsparks commented Aug 12, 2020 via email

@pat-s
Copy link
Member Author

pat-s commented Aug 12, 2020

You triggered a run for your main branch. This will not trigger a run for the update-tic YAML. The latter is configured CRON-only.

Let's wait for tmrw. Chances are that everything will just work then ;)

@adamhsparks
Copy link
Member

I think this is finally fixed, here and on a couple other repositories where I’ve tried it. Will wait another 24hrs to be sure and then close this.

@adamhsparks
Copy link
Member

All good! No error messages today. Thanks for your assistance, @pat-s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants