Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink DOIs against preferred resolver #131

Closed
wants to merge 3 commits into from
Closed

Hyperlink DOIs against preferred resolver #131

wants to merge 3 commits into from

Conversation

katrinleinweber
Copy link

Hello :-)

The DOI foundation recommends this new, secure resolver and Zenodo started using it for its badges as well. Accordingly, this PR updates all DOI links.

Cheers!

PS: In case the .bib files are generated automatically, is their source accessible to a PR like this one?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 87.345% when pulling d841ee1 on katrinleinweber:resolve-DOIs-securely into dbd0547 on lbusett:master.

@katrinleinweber
Copy link
Author

Same error as in the last merged PR, so I guess it is not due to my change suggestion ;-)

@lbusett
Copy link
Contributor

lbusett commented May 28, 2018

Hi,

thanks for the PR. I'll review it shortly. Do not worry about the coveralls fail: I still have to manage for it to work properly (can't manage to have GDAL properly configured).

Lorenzo

@katrinleinweber
Copy link
Author

Sorry for the delay here in resolving these merge conflicts! This was a good opportunity to finally configure a proper mergetool, though :-)

@ranghetti
Copy link
Contributor

I'm closing this pull request because old (I recently succeeded Lorenzo in maintaing the package, so I do not know details related to this PR and why it is wtill open). Feel free to reopen if needed.

@ranghetti ranghetti closed this Dec 1, 2020
@katrinleinweber
Copy link
Author

Hi @ranghetti! It's technically still needed, assuming you want the links to adhere to the DOU foundations recommendation. It's not strictly necessary WRT any functionality ;-)

ranghetti added a commit that referenced this pull request Dec 27, 2020
@ranghetti
Copy link
Contributor

Thank you for your answer; I deepened this PR, noticing that almost all DOIs were already changed, so the PR is not yet necessary. Commit 53f95d4 fixed the two remaining ones.

@ranghetti ranghetti mentioned this pull request Jan 15, 2021
ranghetti added a commit that referenced this pull request Jan 15, 2021
* Update develop version

* DOI preferrer resolver (#131)

* Try fixing #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants