-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds comparing simplify = FALSE for metadata table #221
Conversation
Also regenerated the README.md.
BTW I think we're at the point that the next release is due. |
Nice. Wondering if we should clean up the README a bit more while we are at it. I can clean up the badge list (we don't need two coverage badges, looks like our appveyor setup needs mending since it's not active...) but there's a bit of a philosophical divide between whether pkg root README should be a more minimal motivation/install/quickstart (with the details handled in vignettes linked from the readme) or a more complete all-the-essentials style document. For the former it would be good to run Yes, definitely need to plan a new release on this as well. |
Indeed I had similar thoughts and had noticed |
whoops, I don't think I pulled this into #226 yet... |
Most of it is there in #226, actually. The only thing that's not is the hunk about showing |
Ah, good . Yeah, I don’t think simplify=FALSE has a compelling enough use
case, almost always would want TRUE anyway
On Fri, Dec 7, 2018 at 5:07 PM Hilmar Lapp ***@***.***> wrote:
Most of it is there in #226 <#226>,
actually. The only thing that's not is the hunk about showing
simplify=FALSE
<https://github.com/ropensci/RNeXML/pull/221/files#diff-5140cd39fa2897e01ffbfb8db0999940R104>.
I assumed you decided that doesn't fit well into the intro vignette?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#221 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANleogmLVa71uU4sycktnPHoEDMqeYQks5u2xC0gaJpZM4Y25bk>
.
--
---
Carl Boettiger
http://carlboettiger.info/
|
So close this one then? I'll assume you meant yes. |
Also regenerated the README.md.