Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds comparing simplify = FALSE for metadata table #221

Closed
wants to merge 1 commit into from

Conversation

hlapp
Copy link
Contributor

@hlapp hlapp commented Nov 28, 2018

Also regenerated the README.md.

@hlapp
Copy link
Contributor Author

hlapp commented Nov 28, 2018

BTW I think we're at the point that the next release is due.

@cboettig
Copy link
Member

Nice. Wondering if we should clean up the README a bit more while we are at it. I can clean up the badge list (we don't need two coverage badges, looks like our appveyor setup needs mending since it's not active...) but there's a bit of a philosophical divide between whether pkg root README should be a more minimal motivation/install/quickstart (with the details handled in vignettes linked from the readme) or a more complete all-the-essentials style document. For the former it would be good to run pkgdown::build_site() to get an HTML version of the docs and vignettes as well.... thoughts?

Yes, definitely need to plan a new release on this as well.

@hlapp
Copy link
Contributor Author

hlapp commented Nov 28, 2018

Indeed I had similar thoughts and had noticed pkddown. I moved this to its own issue (#222), continuing there.

@hlapp
Copy link
Contributor Author

hlapp commented Dec 8, 2018

@cboettig am I right that this has been obsoleted by #223 and #226?

@cboettig
Copy link
Member

cboettig commented Dec 8, 2018

whoops, I don't think I pulled this into #226 yet...

@hlapp
Copy link
Contributor Author

hlapp commented Dec 8, 2018

Most of it is there in #226, actually. The only thing that's not is the hunk about showing simplify=FALSE. I assumed you decided that doesn't fit well into the intro vignette?

@cboettig
Copy link
Member

cboettig commented Dec 8, 2018 via email

@hlapp
Copy link
Contributor Author

hlapp commented Dec 8, 2018

So close this one then? I'll assume you meant yes.

@hlapp hlapp closed this Dec 8, 2018
@hlapp hlapp deleted the regen-readme branch December 8, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants