switch from openxlsx to readxl & writexl #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated parsers that rely on xlsx input data (
get_14cpalaeolithic()
,get_14sea()
,get_eubar()
,get_irdd()
). Removedopenxlsx::read.xlsx()
withreadxl::read_excel()
.One question: how is codemeta.json generated; manually or automatically? There openxlsx is still listed.
Had issue with the write
write_c14(. , format = "xlsx")
and tests failed on that stage.@nevrome can you test and verify that the parsers work?