Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from openxlsx to readxl & writexl #111

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Conversation

dirkseidensticker
Copy link
Contributor

Updated parsers that rely on xlsx input data (get_14cpalaeolithic(), get_14sea(), get_eubar(), get_irdd()). Removed openxlsx::read.xlsx() with readxl::read_excel().

One question: how is codemeta.json generated; manually or automatically? There openxlsx is still listed.

Had issue with the write write_c14(. , format = "xlsx") and tests failed on that stage.

@nevrome can you test and verify that the parsers work?

@dirkseidensticker dirkseidensticker linked an issue Sep 1, 2020 that may be closed by this pull request
@dirkseidensticker dirkseidensticker changed the title initial commit for switch from openxlsx to readxl & writexl switch from openxlsx to readxl & writexl Sep 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #111 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   95.10%   95.51%   +0.40%     
==========================================
  Files          33       33              
  Lines        1615     1626      +11     
==========================================
+ Hits         1536     1553      +17     
+ Misses         79       73       -6     
Impacted Files Coverage Δ
R/c14_date_list_write_c14.R 94.11% <100.00%> (ø)
R/get_14cpalaeolithic.R 100.00% <100.00%> (ø)
R/get_14sea.R 100.00% <100.00%> (ø)
R/get_eubar.R 100.00% <100.00%> (ø)
R/get_irdd.R 100.00% <100.00%> (ø)
R/get_calpal.R 98.24% <0.00%> (-1.76%) ⬇️
R/helpers_thesauri.R 100.00% <0.00%> (ø)
R/c14_date_list_classify_material.R 92.00% <0.00%> (+3.76%) ⬆️
R/get_c14data.R 87.69% <0.00%> (+10.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237419b...2a2d20c. Read the comment docs.

@nevrome
Copy link
Member

nevrome commented Sep 1, 2020

Looks fine to me now 👍

@dirkseidensticker dirkseidensticker merged commit 208a468 into master Sep 2, 2020
@dirkseidensticker dirkseidensticker deleted the openxlsx2readxl branch September 2, 2020 12:00
@nevrome
Copy link
Member

nevrome commented Sep 2, 2020

Please remember to document all changes in the NEWS.md file.

You don't have to do this with a PR now if you only edit the NEWS.md - feel free to push directly to the master.

@dirkseidensticker
Copy link
Contributor Author

damn, you are right. sorry. will do after #112 is merged?

@nevrome
Copy link
Member

nevrome commented Sep 2, 2020

Fair enough 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openxlsx reading issues
3 participants