Test ls_tree() with subfolder. #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing out the function
ls_tree()
and observed some strange behavior. I noticed that the tests intests/tree.R
did not cover the use cases described inman/ls_tree.Rd
. Specifically, the presence of a subfolder givesls_tree()
problems.This PR converts the examples from
?ls_tree
into a test file. It also adds additional tests corresponding to the results ofgit ls-tree
.To compare, below is the output of
git ls-tree -lr HEAD
. There are 3 lines corresponding to the 3 files in the repository.In contrast,
ls_tree()
returns 4 lines. It includes the tree subfolder as its own line, and then the final line does not include the file inside the subfolder.Lastly, I found it strange that the argument
tree
accepts the characters"HEAD:subfolder"
and"HEAD:"
, but not"HEAD"
.