Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in compile_taxa.R for user provided table functionality #157

Merged
merged 2 commits into from
Jan 7, 2015

Conversation

andydawson
Copy link
Contributor

Fixed compile_taxa.R so it can now take a user provided table - there was a bug when setting the column number of the conversion list use.list. Also, the warning was always printed, so I added an if statement so it doesn't print when missed is empty.

@andydawson
Copy link
Contributor Author

I also just fixed another bug in this function - in the case where object is a matrix of data frame, we were trying to access the counts object by doing object$counts. I modified it so it instead just uses object.

@SimonGoring
Copy link
Member

Thanks!

On Mon, Oct 20, 2014 at 4:17 PM, Andria Dawson notifications@github.com
wrote:

I also just fixed another bug in this function - in the case where object
is a matrix of data frame, we were trying to access the counts object by
doing object$counts. I modified it so it instead just uses object.


Reply to this email directly or view it on GitHub
#157 (comment).

SimonGoring added a commit that referenced this pull request Jan 7, 2015
Bug fix in compile_taxa.R for user provided table functionality
@SimonGoring SimonGoring merged commit 1160e5d into ropensci:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants