Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplemental river and lake centerlines not available #23

Closed
mps9506 opened this issue Sep 20, 2018 · 3 comments
Closed

Supplemental river and lake centerlines not available #23

mps9506 opened this issue Sep 20, 2018 · 3 comments

Comments

@mps9506
Copy link
Contributor

mps9506 commented Sep 20, 2018

Thank you for the wonderful package.

I am not able to download the 10m river and lake centerline North American supplemental file.

check_data_exist(scale = 10, category = "physical", type = "rivers_north_america")

Returns:

[1] FALSE
Warning message: In check_data_exist(scale = 10, category = "physical", 
type = "rivers_lake_north_america") :   rivers_north_america seems not to be in the list 
for category=physical maybe try the other category of c('cultural', 'physical')

The file location is: https://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/physical/ne_10m_rivers_north_america.zip

The regular rivers_lake_centerline download works for me, but is not the file I'm after:

check_data_exist(scale = 10, category = "physical",  type = "rivers_lake_centerlines")

Any insight would be appreciated. Cheers.

@andysouth
Copy link
Contributor

andysouth commented Sep 21, 2018

Thanks, well spotted !

The warning should now be fixed in the github version (there is a table of available layers and that wasn't in it).

Even in the CRAN version this should still work even though it does give a warning (it tries to download even if not in the table):
rivers <- ne_download(scale = 10, category = "physical", type = "rivers_north_america")

(Note not 'rivers_lake_north_america')

I'll have a look at cleaning up what happens with the warnings generally.

@mps9506
Copy link
Contributor Author

mps9506 commented Sep 21, 2018

Thanks! Works perfectly.
This might be covered already (or should be a new issue), is there a way to load data_list_physical.csv as a dataframe? As a user it would be easier to inspect a dataframe in R to get the filename than load the website and navigate to the file. Furthermore, having the .csv update dynamically might reduce potential issues in the future.
If that would be useful I can work up a pull request.

@andysouth
Copy link
Contributor

andysouth commented Sep 21, 2018 via email

@mps9506 mps9506 closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants