-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch raster -> terra dependency changes #63
Conversation
Thx for doing it! Do you know what kind of format are available in https://www.naturalearthdata.com/features/ ?
|
This is what I have partially implemented but the back conversions break on some of the features, or are non-trivial. Types need to be correctly specified as there is no catch all as |
Yeah ... Can |
Thanks, this works. Build tests on my local machine are clean but I'm not sure how comprehensive unit tests are. |
Many thanks for your work @khufkens @defuneste @maelle |
As long as Would be happy to be mentioned as contributor, thanks! |
@rsbivand, can you give us your opinion to the question of @andysouth [" whether we should change default vector class from sp to sf"]? |
Try |
@khufkens Can you provide information (full name, email) so we can add you as a contributor? |
@PMassicotte for the DESCRIPTION file
|
This patches the
raster
dependency as raised by #60Follow up will deal with the
rgdal
, which is more challenging.rgdal
deals with reading in shape files, and although this can be replaced bysf
the back conversions tosp
for consistency are tedious duesp
, well, not beingsf
.