Grouping, Printing and Formatting #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print method does not work properly
Print method does not work properly Printed out value of grouping variable Included grouping variable value
This is to match the output of dplyr::summarize().
import from magrittr not dplyr
…to grouped_df_PR
…specific and default types.
…rintconcept Conflicts: DESCRIPTION
Fixed some items that Travis was reporting.
Also covr has a known issue of misreporting coverage of lists of functions, so excluding those (which are all tested) from the report.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
========================================
+ Coverage 92.02% 100% +7.97%
========================================
Files 5 6 +1
Lines 163 200 +37
========================================
+ Hits 150 200 +50
+ Misses 13 0 -13
Continue to review full report at Codecov.
|
…ed messages by using modify_if().
This was referenced Jul 11, 2017
elinw
changed the title
|
This is all now in the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies printing and address some of the issues around formatting/significant digits.
The main change is to add a "formatted_value" column so that now levels is only used for levels, and formatted values for printing (and other purposes) are in the new column. This includes both the spark graphs and the dates. If no specific formatted value is declared in the statistic the stored value is converted to a character and used. This means that the display does not add extra 0s. However calculated values at this point still are displaying as is. However those issues will now be easier to address in a flexible way.
A user could define their own formatting using colformat, lucid or their own approach.
I think we should still come up with a default solution for mean and standard deviation but that's a lot simpler than having to do everything.
Some of the tests are failing (adding the extra column required a lot of changes).
