Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comprehensive example of SpatialLinesNetwork() #186

Merged
merged 7 commits into from
Mar 19, 2017

Conversation

Robinlovelace
Copy link
Member

No description provided.

@Robinlovelace
Copy link
Member Author

@richardellison the aim here is to show the user what is going on (partly for my own understanding).

This what I get - makes sense, going from point 1 to 50 on the map:

image

@Robinlovelace
Copy link
Member Author

But this is what I get when I change line 60 to:

#' from_id = 10

image

Not what I was expecting! Explanation of what's going on appreciated.

@richardellison
Copy link
Collaborator

I'm looking into this, taking a bit longer than I expected to track down. It seems the source of the problem is how the igraph nodes are linked back to specific coordinates which is resulting in problems in constructing the final line because in some cases coordinates need to be reversed and the incorrect node coordinates are resulting in this being done incorrectly.

@Robinlovelace
Copy link
Member Author

Hmm yes igraph nodes seem non-trivial. Best of luck with it and let me know if there's anyway I can help. Sorry if I just opened a can of worms! (Heads up @edzer - any guidance welcome.)

@Robinlovelace Robinlovelace merged commit 8efcb9d into ropensci:master Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants