Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perhaps add a return_type: "name" #21

Closed
zachary-foster opened this issue Mar 7, 2017 · 1 comment · Fixed by #22
Closed

Perhaps add a return_type: "name" #21

zachary-foster opened this issue Mar 7, 2017 · 1 comment · Fixed by #22

Comments

@zachary-foster
Copy link
Collaborator

This would apply to functions that use taxonomy's private$get_return_type to return a result, like subtaxa and supertaxa. Instead of returning an ID or whatevs, it would return taxon names.

Seems like it would be an easy add.

Thoughts?
@sckott
Copy link
Contributor

sckott commented Mar 7, 2017

sounds good to me

zachary-foster added a commit that referenced this issue Mar 7, 2017
@zachary-foster
Made more funcs available to NSE
07d4ec4 
Split `classifications` into `id_ classifications` and `name_classifications`.

Moved funcs into `taxonomy` and `taxmap`

resolves #21; adds "name" return type
@zachary-foster zachary-foster mentioned this issue Mar 7, 2017
Merged
@sckott sckott closed this as completed in #22 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made more funcs available to NSE ropensci/taxa
2 participants
@sckott @zachary-foster