isTRUE(travis::uses_github()) always FALSE on R < 3.5 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the output of travis::uses_github() is of type atomic and logical, when it is TRUE is does not pass test isTRUE because of its attributes, at least on R 3.4.4 with travis 0.2.11.9001. It is said in R base 3.4.4 documentation : "isTRUE(x) is an abbreviation of identical(TRUE, x), and so is true if and only if x is a length-one logical vector whose only element is TRUE and which has no attributes (not even names)." thus giving FALSE when there are some attributes, see https://www.r-bloggers.com/working-with-istrue/ for an example. It is not the case for upper R versions, see 3.5 documentation: https://www.rdocumentation.org/packages/base/versions/3.5.0/topics/Logic
|
Thanks. Let's see if we can handle in backports instead: r-lib/backports#22 |
|
Works for me on R 3.4.X. @floriandeboissieu For you as well? Then we can close here. |
|
Should we bump the required backports version? |
pat-s
added a commit
that referenced
this pull request
Oct 14, 2019
pat-s
added a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the output of travis::uses_github() is of type atomic and logical, when it is TRUE is does not pass test isTRUE because of its attributes, at least on R 3.4.4 with travis 0.2.11.9001. It is said in R base 3.4.4 documentation :
"isTRUE(x) is an abbreviation of identical(TRUE, x), and so is true if and only if x is a length-one logical vector whose only element is TRUE and which has no attributes (not even names)."
thus giving FALSE when there are some attributes, see https://www.r-bloggers.com/working-with-istrue/ for an example.
It is not the case for upper R versions, see 3.5 documentation: https://www.rdocumentation.org/packages/base/versions/3.5.0/topics/Logic