Update download_hydat to have an option to bypass the keypress question #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boshek
reviewed
Sep 22, 2021
Co-authored-by: Sam Albers <sam.albers@gmail.com>
Co-authored-by: Sam Albers <sam.albers@gmail.com>
Co-authored-by: Sam Albers <sam.albers@gmail.com>
|
Thanks for the suggestions, all make sense! I've added a news item but I am not sure how you would like the test to look or what it would check, could you please more insight on that? I haven't done much with |
|
Actually I don't it is worth the hassle of testing this. Looks really good to me to close #165. Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to download_hydat to add a parameter
ask, which will bypass the keypress question and proceed directly to the download of HYDAT ifask=FALSE. Defaultask=TRUEmakes no change to the existing workflow with the function.Implemented to have an option for bypassing the keypress when using
download_hydatin another function or other situations when the keypress is not ideal.