Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simpler process for copying document #31

Merged
merged 1 commit into from
Oct 21, 2020
Merged

use simpler process for copying document #31

merged 1 commit into from
Oct 21, 2020

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Oct 21, 2020

I realized that it is simpler to convert the document to text and re-read it than to go through the whole "new_root" path (which I learned through https://community.rstudio.com/t/adding-nodes-in-xml2-how-to-avoid-duplicate-default-namespaces/84870/2).

@zkamvar zkamvar merged commit 30b13fb into master Oct 21, 2020
@zkamvar zkamvar deleted the znk-redo-copy branch October 21, 2020 21:58
@maelle
Copy link
Member

maelle commented Oct 23, 2020

nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants