Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next cran push #93

Closed
sckott opened this issue Mar 21, 2017 · 7 comments
Closed

next cran push #93

sckott opened this issue Mar 21, 2017 · 7 comments

Comments

@sckott
Copy link
Contributor

sckott commented Mar 21, 2017

@infotroph @dlebauer

i've gone through issues, and next cran push will be this milestone https://github.com/ropensci/traits/milestone/6

so I have a few things to deal with before going to cran - let me know if there's anything that should or shouldn't be on the milestone wrt BETYdb

@sckott
Copy link
Contributor Author

sckott commented Mar 26, 2017

thoughts @dlebauer @infotroph ^^

@infotroph
Copy link
Contributor

infotroph commented Mar 26, 2017

@sckott @dlebauer I think you found all the BETY changes that are ready to go. The remaining issues I see all need more thought (#83, #84) and/or coordination with a larger package cleanup (#38, #39).

Of the other issues in this milestone, looks like httr-->crul (#89) is the only one that might require changes in the BETY code. Does crul provide a drop-in replacement for httr::GET?

@sckott
Copy link
Contributor Author

sckott commented Mar 28, 2017

it's easy enough to do the conversion to crul - but I think I’ll move it to the next milestone just to speed up this one

@infotroph
Copy link
Contributor

May need to revisit #52 -- include_unchecked only works in some API versions. We should resolve this before release.

@dlebauer
Copy link
Collaborator

dlebauer commented Mar 29, 2017 via email

@dlebauer
Copy link
Collaborator

Hi @sckott when do you think the next version will be released to CRAN? There are some useful changes that Chris did that would be great to have available in the official version.

@sckott
Copy link
Contributor Author

sckott commented Dec 12, 2018

the next milestone is https://github.com/ropensci/traits/milestone/4 a few of the issues will be very quick, and the others i'll poke at and may move to a future milestone if they will take too long. - so soonish

@sckott sckott closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants