New website: effect on package?

[peterdesmet]

I just read that https://waterinfo.be got upgraded (December 2020):

@stijnvanhoey Should we run the tests to see if all functions in the package still operate as intended?

[stijnvanhoey]

afaik the underlying KIWIS API has not changed and adjustments are purely frontend, so we should be fine. However, it might be a good idea to have a regular check of the unit tests like we do for the python version, https://github.com/fluves/pywaterinfo/actions (using github actions) to see if such alterations have any effect on the wateRinfo implementation. @peterdesmet do you have experience with R package unit tests in github actions?

[peterdesmet]

Yes, @damianooldoni has some set up for other packages. Will do so here.

[peterdesmet]

The GitHub actions are now implemented and the build checks pass validation, so the website has no effect.

The R CMD Check for the development version of R is unstable however, often resulting in an overall failed check. Example: https://github.com/ropensci/wateRinfo/runs/2498444787?check_suite_focus=true @stijnvanhoey do we want to keep this one in, or reduce it to release version of R (on Windows, Ubuntu, Mac)?

[stijnvanhoey]

I would focus on the release version of R for this package and remove the dev one, thanks a lot!

[peterdesmet]

I removed it, but am now getting an error on Ubuntu (timeout), which I didn't get before. Maybe it is a one time thing?

[peterdesmet]

Seemed to be a temporary fail. All tests pass now: https://github.com/ropensci/wateRinfo/runs/2603640203 Status and codecov are indicated in README: https://github.com/ropensci/wateRinfo#readme