Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

physprop fails on windows #17

Closed
eduardszoecs opened this issue Aug 20, 2015 · 2 comments
Closed

physprop fails on windows #17

eduardszoecs opened this issue Aug 20, 2015 · 2 comments
Assignees
@eduardszoecs
Labels
bug Unexpected problem or unintended behavior

Comments

@eduardszoecs
Copy link
Member

See appveyor results:

1. Failure (at test-physprop.R#8): physprop returns correct results ------------
fl$cas not equal to "50-00-0"
1 string mismatches:
x[1]: "50-00-0"
y[1]: "�000050-00-0"

This happens because sub() doesn't work. Possible workarounds:

  • Hardcode encoding
  • ???
@eduardszoecs eduardszoecs added bug Unexpected problem or unintended behavior Windows labels Aug 20, 2015
@eduardszoecs eduardszoecs self-assigned this Aug 20, 2015
@eduardszoecs
Copy link
Member Author

Possible workaround:
Set UTF8 before each gsub():

Encoding(x) <- 'UTF-8'

Or set encoding in getURL?

Add more tests (for cname, mw, and so on..)!

eduardszoecs added a commit that referenced this issue Aug 20, 2015
@eduardszoecs
Possible fix for issue #17
67ea91b
@eduardszoecs
Copy link
Member Author

fixed with commit bb6416c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eduardszoecs eduardszoecs

Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eduardszoecs