Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip pkg #573

Closed
wants to merge 3 commits into from
Closed

pip pkg #573

wants to merge 3 commits into from

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jan 15, 2022

Enables pip install

@@ -0,0 +1,39 @@
[metadata]
name=pydcm2niix
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer:

Suggested change
name=pydcm2niix
name=dcm2niix

but was getting errors:

The name 'dcm2niix' isn't allowed. See https://pypi.org/help/#project-name for more information.

Copy link
Contributor Author

@casperdcl casperdcl Jan 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstutters are you OK with this pull request? I notice you have a repository named pydcm2niix.

Interesting. Ideally this PR should use simply dcm2niix anyway. I can raise a request following https://www.python.org/dev/peps/pep-0541/#how-to-request-a-name-transfer (i.e. https://github.com/pypa/pypi-support/issues/new?labels=PEP+541&template=pep541-request.yml&title=PEP+541+Request%3A+dcm2niix) if you want @neurolabusc?

@neurolabusc
Copy link
Collaborator

@jstutters are you OK with this pull request? I notice you have a repository named pydcm2niix.

@jstutters
Copy link

Thanks for checking. No objection. If I do ever get any further with the work I had in mind for my project it would be better contributed as a follow-up to this PR anyway.

@casperdcl
Copy link
Contributor Author

Thanks @jstutters.

@neurolabusc what about my suggestion of filing a request for dcm2niix though? Seems to me to be a better solution.

@neurolabusc
Copy link
Collaborator

@casperdcl I think it would be ideal if the pip could install the latest stable release of dcm2niix, and the package name dcm2niix sounds reasonable. I am not familiar with pip package management, and am unsure how to proceed. Do I have to request a change, or do you instigate this to have the name associated with this github repository?

@casperdcl
Copy link
Contributor Author

casperdcl commented Jan 17, 2022

@neurolabusc at least one of us needs an account with PyPI. I maintain a lot of PyPI packages so I can put in the request and do general maintenance legwork (making sure releases are in sync etc) if you're happy - let me know :)

If so, at any point in future I can also add maintainers to the PyPI package.

@neurolabusc
Copy link
Collaborator

@casperdcl thanks for volunteering to take on the role of dcm2niix pip install maintainer. Please proceed. Tell me if there is anything else I need to do. If at some future stage you feel you can no longer fill this role, please let the community know. My recent work with Debian maintainer @yarikoptic has allowed me to recognize how much implicit knowledge and skill is required to support packages.

@neurolabusc
Copy link
Collaborator

  1. I am going to close this pull request. Please generate a new one when you are ready.
  2. Please make all pull requests to the development branch. The master branch is the current stable release. Twice a year (spring, autumn) advanced users who have access to a lot of edge case clinical data that can not be shared are asked to validate the development branch, and once it is vetted it is released as the next stable release.

casperdcl added a commit to AMYPAD/dcm2niix that referenced this pull request May 9, 2022
- pydcm2niix => dcm2niix
- thanks to pypi/support#1609
- closes rordenlab#573
@casperdcl casperdcl mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants