Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ros2_control #1

Closed
Karsten1987 opened this issue Sep 15, 2017 · 9 comments

Comments

@Karsten1987
Copy link
Collaborator

commented Sep 15, 2017

Top Level issue referencing all pending PRs

@bmagyar

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

Thanks Karsten! All merged and ready to demo ;)

Even though it is only demo mode I have one comment that should be sorted: visibility_control.h is duplicated in all packages. This is something that should make it into a core ROS2 package and probably even included with a #include <ros2/ros2.h>

@bmagyar

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

@Karsten1987 Please add a short summary & steps to compile and set up to the readme .

@chapulina

This comment has been minimized.

Copy link

commented Nov 12, 2018

As indicated on the README, the code in this repository is still a proof of concept. It may be worth it ticketing issues listing what's left for this to be recommended for use. Will there be a Crystal release?

@bmagyar

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

We don't have anyone currently working on ros2_control but we'd gladly welcome merge requests or even a new maintainer for that role. It wouldn't take more than an hours worth of meeting to come up with a roadmap that goes beyond the proof of concept.

I personally won't be able to dedicate time to it until next year.

@GavinStrunk

This comment has been minimized.

Copy link

commented Nov 16, 2018

@bmagyar @chapulina Hey I have been looking at this repo thinking I would be interested in contributing and maintaining it. I would definitely like some help in terms of defining a roadmap, because it is a little unclear to me what people would like out of this compared to ros_controls beyond using some of the new functionality in ros2. Do you have a recommendation on how people have setup this type of meeting in the past?

@chapulina

This comment has been minimized.

Copy link

commented Nov 16, 2018

Maybe a discourse post with some ideas and asking for feedback from the community could be a good starting point. It would also be nice to describe the current state of the code and what's missing - maybe @Karsten1987 has the most context?

@bmagyar

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

@GavinStrunk

This comment has been minimized.

Copy link

commented Nov 16, 2018

Yea sounds good to me. I'm pretty flexible in the next week so if there is a day and time that works for both of you I can make it work. I'm on Eastern US time zone.

@chapulina

This comment has been minimized.

Copy link

commented Nov 16, 2018

I'm mainly interested in knowing the roadmap so that we can plan porting gazebo_ros_control accordingly. I've actually never used ros_control, so I think I'd be of little help to you 😬

Karsten1987 pushed a commit to Karsten1987/ros2_control that referenced this issue Jan 23, 2019
Ros2 master api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.