Initialize the controller manager services after initializing resource manager #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
arne48,
bijoua29,
bmagyar,
DasRoteSkelett,
destogl and
VanshGehlot
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
- Coverage 47.89% 47.87% -0.03%
==========================================
Files 41 41
Lines 3451 3453 +2
Branches 1876 1878 +2
==========================================
Hits 1653 1653
Misses 444 444
- Partials 1354 1356 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
olivier-stasse
approved these changes
Jan 5, 2024
saikishor
added
the
backport-iron
bmagyar
approved these changes
Jan 8, 2024
This was referenced Jan 16, 2024
Merged
HovorunB
added a commit
to pixel-robotics/ros2_control
that referenced
this pull request
Jan 17, 2024
… resource manager (backport ros-controls#1271) (ros-controls#1278)" This reverts commit 9387936.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing CM services before initializing the resource manager might be a bad idea as the spawners might trigger the controller activation even before the actual system is ready. Exposing it later, might avoid such issues
Fixes #1262