-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a ros2_control user I would like to define transmissions for my robots #32
Comments
hi, what's the status of this port? Karsten's PR has a number of missing things like parsing in actuators, and it's not a 1:1 port with minimal changes from ros1. |
@ddengster I should have marked this PR as draft. I am agreeing with @bmagyar review and most likely that transmission interface should have a new design in the first place. I just need something going for get started with the I think this issue is the right place to voice some concerns or design proposals for a ROS2 implementation. |
No problem, @Karsten1987. I also happen to be working on a minimal With regards to the PR, I was expecting something closer to a 1-to-1 for the parser - doing a minimal working port first from ros_control, then applying breaking design changes later. Also I'm not sure if we need a TransmissionParser object instantiation? I just need a function call to populate my TransmissionInfo data structures. But then again I'm not of the mindset that we need to 'objectify' things to get our code to do what it needs to do. |
Over the years there were quite a few attempts at improving Also, I agree with removing classes when not needed. If a class contains no state but only a bunch of (hopefully static) functions, we have a better name for that: namespace. |
I'm assuming you're referring to Perhaps I'll pick an example to narrow it down? There's plenty of Anyway, let me know and mabye we can trash it out. |
I saw that @bmagyar has merged transmission_interface in ros2_control/master. Is there any plan for the following data structures.
|
Where do you need those informations? |
We are missing transmission-loader and an xml format to close this. |
Done in the recent ros2_control release, 2.6 |
Design
Port over transmission_interface
The text was updated successfully, but these errors were encountered: